Added dfn tag #235
Added dfn tag #235
Conversation
pascalwengerter left a comment
pascalwengerter left a comment There was a problem hiding this comment.
Good work overall, just some minor issues!
Please also remove the u tag from this branch/PR and open a separate pull request for the separate feature/component :)
| @@ -0,0 +1,49 @@ | |||
| # matestack core component: Hr | |||
| @@ -0,0 +1,49 @@ | |||
| # matestack core component: Hr | |||
| | |||
| Show [specs](/spec/usage/components/hr_spec.rb) | |||
| | ||
| ```html | ||
| <div id="foo" class="bar"> | ||
| <u class="u-class"> |
There was a problem hiding this comment.
Missing </u> closing tag
| | ||
| ```html | ||
| <div id="foo" class="bar"> | ||
| <u id="u-id"> |
There was a problem hiding this comment.
Missing closing tag
| </div> | ||
| ``` | ||
| | ||
| ## Example 2 |
There was a problem hiding this comment.
Please provide one example using the text: 'Whatever and one using
u do plain 'Whatever' end Just like in the spec file!
| @@ -0,0 +1,49 @@ | |||
| # matestack core component: Hr | |||
| | ||
| ```html | ||
| <div id="foo" class="bar"> | ||
| <dfn id="dfn-id"> |
There was a problem hiding this comment.
Missing closing tag
| | ||
| ```html | ||
| <div id="foo" class="bar"> | ||
| <dfn class="dfn-class"> |
There was a problem hiding this comment.
Missing closing tag
| Hey @Manukam do you need any help to go the final steps on this one? 🙌 |
pascalwengerter left a comment
pascalwengerter left a comment There was a problem hiding this comment.
Unresponsive contributor, I'll merge and correct the minor things myself.
3 participants
Issue #184: Add dfn tag to core components
Changes
Notes