Add legend tag #229
Merged
Add legend tag #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pascalwengerter suggested changes Oct 8, 2019
Contributor
pascalwengerter left a comment
pascalwengerter left a comment There was a problem hiding this comment.
Looking good, few steps until we're ready to merge!
docs/components/legend.md Outdated
| This component can take 2 optional configuration params and optional content. | ||
| | ||
| #### # id (optional) | ||
| Expects a string with all ids the main should have. |
docs/components/legend.md Outdated
| Expects a string with all ids the main should have. | ||
| | ||
| #### # class (optional) | ||
| Expects a string with all classes the main should have. |
docs/components/legend.md Outdated
| #### # class (optional) | ||
| Expects a string with all classes the main should have. | ||
| | ||
| ## Example |
Contributor
There was a problem hiding this comment.
Please provide another example that can do such as
legend id: "foo", class: "bar", text: "Hello World"
or similiar. Then this component can be used as a nice one-liner :)
Contributor
There was a problem hiding this comment.
And add a test for it, too
Contributor Author
| Same here @pascalwengerter :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please make sure to target feature and bugfix requests to develop branch
Issue #196
Add HTML
legendtag to core componentsChanges