[0018] Update cbuffer representation #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
CBuffer will use the `spirv.Layout` type. We leave open how to handle substructures in the cbuffer. Contributes to llvm/llvm-project#138276.
Collaborator
| This is superseded at this point given that we'll be using the explicit padding approach instead. In any case, LGTM if you want to merge it for historical reasons, otherwise we should probably just close this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
CBuffer will use the
spirv.Layouttype. We leave open how to handlesubstructures in the cbuffer.
Contributes to llvm/llvm-project#138276.