Add: fibonacci memoization in JavaScript #249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kelvins requested changes Oct 12, 2023
There was a problem hiding this comment.
Thanks @eric-vantunes! There's a conflict with the README file, could you please fix it?
| <a href="./CONTRIBUTING.md"> | ||
| <img align="center" height="25" src="./logos/github.svg" /> | ||
| </a> | ||
| </td> |
| <img align="center" height="25" src="./logos/github.svg" /> | ||
| </a> | ||
| </td> | ||
| </tr> |
There was a problem hiding this comment.
The indentation is wrong, I believe you should add 4 spaces.
| }; | ||
| | ||
| return fibonacci; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Could you please add a main function to validate/exemplify the solution?
| @@ -0,0 +1,14 @@ | |||
| /** | |||
| * A memoização é uma abordagem que podemos usar para escrever a função fibonacci. Resumindo é uma técnica de otimização em que amarzenamos os valores de resultados anteriores, de modo semelhante a um cache. | |||
There was a problem hiding this comment.
Could you please translate it to english?
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td><a href="https://www.ime.usp.br/~pf/algoritmos/aulas/recu.html">Fibonacci Memoization</a></td> |
There was a problem hiding this comment.
Suggested change
| <td><a href="https://www.ime.usp.br/~pf/algoritmos/aulas/recu.html">Fibonacci Memoization</a></td> | |
| <td><a href="https://en.wikipedia.org/wiki/Fibonacci_sequence">Fibonacci (Memoization)</a></td> |
| Done by commit 4994418. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I added a javascript memoization algorithm is an optimization of the standard recursive Fibonacci algorithm using a technique called memoization.