add new python algorithm #225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kelvins reviewed Oct 5, 2023
Owner
There was a problem hiding this comment.
Hi @fgrdz, thanks for the contribution, a few comments:
- Add a
mainfunction (example) as a validation/example of usage - Make sure you follow the PEP8 style guide
- Make sure the CI workflow is passing (lint and link checkers)
- Translate the comments to English
- Rename the file to
roman_numerals.py - Add this new algorithm to the README (Extra section)
Owner
| Closing stale PR (more than 30 days without interactions). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
I added a python algorithm, which converts integers to roman numerals