Skip to content

Speed up the Eq instance for TArray #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Speed up the Eq instance for TArray #37

wants to merge 1 commit into from

Conversation

treeowl
Copy link
Contributor

@treeowl treeowl commented Sep 16, 2020

We don't actually have to check all the elements to see that
two TArrays are equal.
@treeowl
Copy link
Contributor Author

treeowl commented Sep 16, 2020

This instance semantically matches the old one, but it's pretty weird for empty arrays. I've opened a GHC ticket for my concern about the underlying Array instance.
@treeowl
Copy link
Contributor Author

treeowl commented Sep 21, 2020

It looks increasingly likely that the bug in the Array instance will be fixed. @bgamari, should I change this PR to make it match what the new Eq Array instance will probably do?
@treeowl
Speed up the Eq instance for TArray
d124cdf 
We don't actually have to check all the elements to see that two `TArray`s are equal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@treeowl