Skip to content

Conversation

@KingDarBoja
Copy link
Contributor

  • Place dev and test packages inside setup python file.
  • Provide contributing docs for pip and conda developers.
  • Add Makefile
@coveralls
Copy link

coveralls commented Feb 26, 2020

Coverage Status

Coverage remained the same at 93.548% when pulling fa8af4c on KingDarBoja:contributing-docs into d29cc6f on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.548% when pulling 30032f9 on KingDarBoja:contributing-docs into d29cc6f on graphql-python:master.

Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks @KingDarBoja ! Couple of changes needed but otherwise this looks good

@KingDarBoja KingDarBoja requested a review from jkimbo February 27, 2020 03:51
@jkimbo
Copy link
Member

jkimbo commented Mar 14, 2020

Thanks @KingDarBoja

@jkimbo jkimbo merged commit 88089b6 into graphql-python:master Mar 14, 2020
@KingDarBoja KingDarBoja deleted the contributing-docs branch March 14, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants