Use context option (if provided) #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @luisincrespo Thanks for the PR! Any tests checking this change would be great so the issue is not repeated in the future :) |
| @syrusakbary of course, will do as soon as I get the time today |
| The context option became useless again in the master branch. The commit that makes context option useless: Seems that users are forced to subclass |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related to #18
Currently, the
GraphQLViewclass accepts thecontextkeyword argument when initializing, but it's not using it to set thecontext_valuewhen executing the query.This PR modifies the
get_contextinstance method insideGraphQLViewso that thecontextoption is used when it is provided, defaulting torequestotherwise.