Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Sep 14, 2021

We previously added support for AuditLog and RequestLog protos in v2.5.0. This PR also adds support for google.iam.v1.logging.AuditData by importing the google-cloud-iam-logging dependency

Fixes #363 🦕

@daniel-sanche daniel-sanche requested review from a team as code owners September 14, 2021 22:37
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Sep 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2021
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche daniel-sanche merged commit e3a1eba into main Oct 5, 2021
@daniel-sanche daniel-sanche deleted the audit-data-2 branch October 5, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.

3 participants