Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

docs(samples): added comment to webhook sample #211

Merged
merged 3 commits into from
Nov 12, 2021
Merged

docs(samples): added comment to webhook sample #211

merged 3 commits into from
Nov 12, 2021

Conversation

@galz10
Copy link
Contributor

@galz10 galz10 commented Nov 12, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@galz10 galz10 requested a review from a team as a code owner November 12, 2021 22:40
@galz10 galz10 requested a review from dinagraves November 12, 2021 22:40
@product-auto-label product-auto-label bot added the api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. label Nov 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 12, 2021
dandhlee
dandhlee reviewed Nov 12, 2021
View reviewed changes
leahecole
leahecole reviewed Nov 12, 2021
View reviewed changes
@galz10 @leahecole
Update samples/snippets/webhook.py
66039e7 
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@galz10 galz10 requested a review from dandhlee November 12, 2021 22:56
@galz10 galz10 requested a review from leahecole November 12, 2021 22:58
dandhlee
dandhlee approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@galz10 galz10 merged commit 4d36e31 into googleapis:main Nov 12, 2021
@galz10 galz10 deleted the webhook-comments branch November 12, 2021 23:44
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 15, 2021
@release-please
chore: release 1.7.0 (#208)
4b1c074 
🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/python-dialogflow-cx/compare/v1.6.0...v1.7.0) (2021-11-12) ### Features * allow setting custom CA for generic webhooks ([#207](https://www.github.com/googleapis/python-dialogflow-cx/issues/207)) ([441d66b](https://www.github.com/googleapis/python-dialogflow-cx/commit/441d66b3864c34cf37570b6c58ccf097eb20e919)) ### Documentation * **samples:** added comment to webhook sample ([#211](https://www.github.com/googleapis/python-dialogflow-cx/issues/211)) ([4d36e31](https://www.github.com/googleapis/python-dialogflow-cx/commit/4d36e31f20e38755dd5d4a7a92bb8c48722cb11e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

3 participants

@galz10 @leahecole @dandhlee