feat: Updating the Tensorboard uploader to use the new batch write API so it runs more efficiently #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: aiplatform 
yfang1 changed the title 
karthikv2k approved these changes Sep 21, 2021
| self._run_name_to_run_resource_name: Dict[str, str] = {} | ||
| self._run_tag_name_to_time_series_name: Dict[(str, str), str] = {} | ||
| | ||
| def get_run_resource_name(self, run_name: str): |
There was a problem hiding this comment.
better to rename it as create_or_get_run_resource_name ?
There was a problem hiding this comment.
It doesn't actually "create" a resource name though, but I see what you're saying.
Gonna leave the name as is, but will add doc string to describe what it does.
…I so it runs more efficiently
vinnysenthil approved these changes Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
b/190431961.
go/tb-uploader-speedup
Ran the new code for scalar, tensor, blob data. Looks fine to me.