Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

feat: add code samples and tests for overlay creation #39

Merged
merged 3 commits into from
Mar 12, 2021
Merged

feat: add code samples and tests for overlay creation #39

merged 3 commits into from
Mar 12, 2021

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Mar 10, 2021

b:181782257
@irataxy irataxy requested a review from a team as a code owner March 10, 2021 18:35
@product-auto-label product-auto-label bot added the api: transcoder Issues related to the googleapis/nodejs-video-transcoder API. label Mar 10, 2021
@snippet-bot
Copy link

snippet-bot bot commented Mar 10, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021 •
edited
Loading

Codecov Report

Merging #39 (9d65c25) into master (ecac4fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #39 +/- ## ======================================= Coverage 96.20% 96.20% ======================================= Files 5 5 Lines 1581 1581 Branches 61 61 ======================================= Hits 1521 1521 Misses 59 59 Partials 1 1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecac4fd...9d65c25. Read the comment docs.
bcoe
bcoe suggested changes Mar 12, 2021
View reviewed changes
Copy link

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, we usually hyphen-case JavaScript files, so:

create-job-with-static-overlay.js
samples/createJobWithStaticOverlay.js
@@ -0,0 +1,119 @@
/**
* Copyright 2021, Google, Inc.
* Licensed under the Apache License, Version 2.0 (the "License");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we usually hyphen case our Node.js samples.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Do I need to change this? I will then have to rename every .js file in the samples.
@bcoe bcoe merged commit 47686fa into googleapis:master Mar 12, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 15, 2021
@release-please
chore: release 1.3.0 (#41)
19a8e6c 
🤖 I have created a release \*beep\* \*boop\* --- ## [1.3.0](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.2.0...v1.3.0) (2021-03-15) ### Features * **samples:** add code samples and tests for overlay creation ([#39](https://www.github.com/googleapis/nodejs-video-transcoder/issues/39)) ([47686fa](https://www.github.com/googleapis/nodejs-video-transcoder/commit/47686fa17c5e5164f6d5f5f37f09d37bd9844cc3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: transcoder Issues related to the googleapis/nodejs-video-transcoder API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

2 participants

@irataxy @bcoe