fix: convert AdditionalMessage param into string type CustomMessage #535
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #517 🦕
The original intent of additionalMessage was to let users manually override the entire ReportedErrorEvent.message field. Which according to specs, must include the error message & stack trace in the format:
errorMessage + "\n" + stacktrace. Additionally error message must be a string.PR changes:
additionalMessageparam intocustomMessageparam to be clearer about its intended usecustomMessageparam into only string, not object, type. As originally intended per original inline documentation:Tests passing.
Breaking or nonbreaking
I'm not sure whether to mark this PR as breaking or nonbreaking. Typically a change in an attr type warrants
breakingbut in this case, this attribute never worked, and is only introduced at the client lib layer...