Revert "fix: skip failing backup tests for now" #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 990c612.
google-cla bot added the cla: yes 
product-auto-label bot added the api: spanner 
skuruppu approved these changes Nov 17, 2020
Codecov Report
@@ Coverage Diff @@ ## master #634 +/- ## ========================================= Coverage 84.04% 84.04% - Complexity 2502 2503 +1 ========================================= Files 141 141 Lines 13810 13810 Branches 1318 1318 ========================================= Hits 11607 11607 Misses 1657 1657 Partials 546 546 Continue to review full report at Codecov.
|
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 17, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.4](https://www.github.com/googleapis/java-spanner/compare/v3.0.3...v3.0.4) (2020-11-17) ### Reverts * Revert "fix: skip failing backup tests for now" (#634) ([b22cd7d](https://www.github.com/googleapis/java-spanner/commit/b22cd7dfc377a0445534946af29500cee316e6b1)), closes [#634](https://www.github.com/googleapis/java-spanner/issues/634) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#4393 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@1986171 feat: added a new API method ListBuildTargets to list build targets that a user has access to This API method does not require a input for the user account. It will fetch the current user account from the service account credential file automatically. PiperOrigin-RevId: 383511703 Source-Link: googleapis/googleapis@cdb30b6 feat(pubsub): Add method signature for Subscriber.Pull without the deprecated return_immediately field. PiperOrigin-RevId: 383459959 Source-Link: googleapis/googleapis@fe3cc5e chore: regenerate API index Source-Link: googleapis/googleapis@b755d25 feat(monitoring/dashboard): added validation only mode when writing dashboards feat: added alert chart widget PiperOrigin-RevId: 383440655 Source-Link: googleapis/googleapis@b5532bb build(vpcaccess): update package name PiperOrigin-RevId: 383434153 Source-Link: googleapis/googleapis@a9d8182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These tests were previously disabled due to a bug in production, which has been fixed.