fix: simplify AckSetTrackerImpl and make acks after shutdown not cause a permanent error #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…e a permanent error
google-cla bot added the cla: yes 
product-auto-label bot added the api: pubsublite 
manuelmenzella-google approved these changes Sep 13, 2021
...ublite/src/main/java/com/google/cloud/pubsublite/cloudpubsub/internal/AckSetTrackerImpl.java Outdated Show resolved Hide resolved
dpcollins-google added kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
gcf-merge-on-green bot removed the automerge gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.6](https://www.github.com/googleapis/java-pubsublite/compare/v1.0.5...v1.0.6) (2021-09-13) ### Bug Fixes * simplify AckSetTrackerImpl and make acks after shutdown not cause a permanent error ([#872](https://www.github.com/googleapis/java-pubsublite/issues/872)) ([98ceff0](https://www.github.com/googleapis/java-pubsublite/commit/98ceff05e69ef4659dcb7650fabd3766d16ef1b8)) ### Dependencies * update dependency com.google.cloud:google-cloud-pubsub to v1.114.3 ([#857](https://www.github.com/googleapis/java-pubsublite/issues/857)) ([d312080](https://www.github.com/googleapis/java-pubsublite/commit/d312080cc4b9c74eab6023703e37511df270feb8)) * update dependency com.google.cloud:pubsublite-beam-io to v0.19.5 ([#830](https://www.github.com/googleapis/java-pubsublite/issues/830)) ([3a74d32](https://www.github.com/googleapis/java-pubsublite/commit/3a74d32d091e712b2c9f8be210905c3548f5ccf4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #870 ☕️