This repository was archived by the owner on Sep 16, 2023. It is now read-only.
feat: add queue_ttl to Build, invert_regex to RepoSource #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency)
googlebot added the cla: yes | @chingor13 PTAL |
Codecov Report
@@ Coverage Diff @@ ## master #100 +/- ## ============================================ + Coverage 77.56% 79.91% +2.34% - Complexity 84 99 +15 ============================================ Files 6 6 Lines 682 682 Branches 2 2 ============================================ + Hits 529 545 +16 + Misses 151 135 -16 Partials 2 2
Continue to review full report at Codecov.
|
chingor13 suggested changes Mar 19, 2020
There was a problem hiding this comment.
This seems to include new client code as well.
We need to add a proto-google-cloud-build-v1/clirr-ignored-differences.xml file with:
<?xml version="1.0" encoding="UTF-8"?> <!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html --> <differences> <difference> <differenceType>7012</differenceType> <className>com/google/cloudbuild/v1/*OrBuilder</className> <method>* get*(*)</method> </difference> <difference> <differenceType>7012</differenceType> <className>com/google/cloudbuild/v1/*OrBuilder</className> <method>boolean contains*(*)</method> </difference> <difference> <differenceType>7012</differenceType> <className>com/google/cloudbuild/v1/*OrBuilder</className> <method>boolean has*(*)</method> </difference> </differences>The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency)
chingor13 suggested changes Mar 19, 2020
The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency)
| @chingor13 PTAL (all tests passed) |
chingor13 changed the title chingor13 approved these changes Mar 20, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 30, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/java-cloudbuild/compare/v1.0.3...v1.1.0) (2020-03-30) ### Features * add queue_ttl to Build, invert_regex to RepoSource ([#100](https://www.github.com/googleapis/java-cloudbuild/issues/100)) ([db14077](https://www.github.com/googleapis/java-cloudbuild/commit/db14077a07f54a260d26483868866b16b200cd2b)) ### Dependencies * update dependency com.google.api:api-common to v1.9.0 ([#112](https://www.github.com/googleapis/java-cloudbuild/issues/112)) ([76452e2](https://www.github.com/googleapis/java-cloudbuild/commit/76452e288e5d4215057c369e21102009b9ca27b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this pull request Mar 31, 2020
e44ccd9 commit e44ccd9 Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Mon Mar 30 22:38:07 2020 +0000 chore: release 1.1.0 (#102) 🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/java-cloudbuild/compare/v1.0.3...v1.1.0) (2020-03-30) ### Features * add queue_ttl to Build, invert_regex to RepoSource ([#100](https://www.github.com/googleapis/java-cloudbuild/issues/100)) ([db14077](https://www.github.com/googleapis/java-cloudbuild/commit/db14077a07f54a260d26483868866b16b200cd2b)) ### Dependencies * update dependency com.google.api:api-common to v1.9.0 ([#112](https://www.github.com/googleapis/java-cloudbuild/issues/112)) ([76452e2](https://www.github.com/googleapis/java-cloudbuild/commit/76452e288e5d4215057c369e21102009b9ca27b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
e44ccd9 commit e44ccd9 Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Mon Mar 30 22:38:07 2020 +0000 chore: release 1.1.0 (#102) 🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/java-cloudbuild/compare/v1.0.3...v1.1.0) (2020-03-30) ### Features * add queue_ttl to Build, invert_regex to RepoSource ([#100](https://www.github.com/googleapis/java-cloudbuild/issues/100)) ([db14077](https://www.github.com/googleapis/java-cloudbuild/commit/db14077a07f54a260d26483868866b16b200cd2b)) ### Dependencies * update dependency com.google.api:api-common to v1.9.0 ([#112](https://www.github.com/googleapis/java-cloudbuild/issues/112)) ([76452e2](https://www.github.com/googleapis/java-cloudbuild/commit/76452e288e5d4215057c369e21102009b9ca27b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency).
The change in license year is caused by moving to
bazel_librarymethod, which uses templates with updated year. Base on our discussion this morning, I assume it is still ok (given that github history prevails).