fix: filter limit constant #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Should 20 KB not 20 MB
google-cla bot added the cla: yes 
product-auto-label bot added the api: bigtable 
igorbernstein2 added the type: bug igorbernstein2 added the automerge 
| Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green bot removed the automerge 
mutianf requested changes Apr 28, 2021
There was a problem hiding this comment.
Looks like the test also needs to be updated:
[INFO] Running com.google.cloud.bigtable.data.v2.models.QueryTest Error: Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.579 s <<< FAILURE! - in com.google.cloud.bigtable.data.v2.models.QueryTest Error: com.google.cloud.bigtable.data.v2.models.QueryTest.filterTestWithExceptions Time elapsed: 0.563 s <<< FAILURE! value of : throwable.getMessage() expected to contain: filter size can't be more than 20MB but was : filter size can't be more than 20KB at com.google.cloud.bigtable.data.v2.models.QueryTest.filterTestWithExceptions(QueryTest.java:134) Caused by: java.lang.IllegalArgumentException: filter size can't be more than 20KB at com.google.common.base.Preconditions.checkArgument(Preconditions.java:144) at com.google.cloud.bigtable.data.v2.models.Query.filter(Query.java:172) 
Codecov Report
@@ Coverage Diff @@ ## master #787 +/- ## ============================================ + Coverage 83.44% 83.49% +0.05% - Complexity 1311 1315 +4 ============================================ Files 114 114 Lines 7799 7806 +7 Branches 442 446 +4 ============================================ + Hits 6508 6518 +10 + Misses 1036 1033 -3 Partials 255 255
Continue to review full report at Codecov.
|
kolea2 approved these changes May 5, 2021
mutianf added the kokoro:force-run mutianf approved these changes May 5, 2021
yoshi-kokoro removed the kokoro:force-run | Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green bot removed the automerge mutianf added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run gcf-merge-on-green bot pushed a commit that referenced this pull request May 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.24.1](https://www.github.com/googleapis/java-bigtable/compare/v1.24.0...v1.24.1) (2021-05-11) ### Bug Fixes * filter limit constant ([#787](https://www.github.com/googleapis/java-bigtable/issues/787)) ([04f8ad4](https://www.github.com/googleapis/java-bigtable/commit/04f8ad463d1fa9efe0ab941ee5f3d0794baed814)) * fix flaky test ([#798](https://www.github.com/googleapis/java-bigtable/issues/798)) ([83e0e8c](https://www.github.com/googleapis/java-bigtable/commit/83e0e8cf2cdbc143c10ce0f8b053096d61d5686f)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#805](https://www.github.com/googleapis/java-bigtable/issues/805)) ([a498687](https://www.github.com/googleapis/java-bigtable/commit/a498687d15dd9af35c57b0df6d08c87ef36833da)) ### Documentation * update the comments in Cloud Bigtable RestoreTable API to reflect the new API capability ([#804](https://www.github.com/googleapis/java-bigtable/issues/804)) ([f5e5d5a](https://www.github.com/googleapis/java-bigtable/commit/f5e5d5ac196529d5b070ef5fd8118038fec2e2de)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kolea2 pushed a commit to kolea2/java-bigtable that referenced this pull request May 20, 2021
* fix: filter limit constant Should 20 KB not 20 MB * fix test (cherry picked from commit 04f8ad4)
kolea2 added a commit that referenced this pull request May 21, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request May 24, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.22.0-sp.1](https://www.github.com/googleapis/java-bigtable/compare/1.22.0...v1.22.0-sp.1) (2021-05-21) ### Features * configure initial sp version ([#829](https://www.github.com/googleapis/java-bigtable/issues/829)) ([47480c5](https://www.github.com/googleapis/java-bigtable/commit/47480c55ab08b80154a4a7d2bb76a9dccfcdea03)) ### Bug Fixes * filter limit constant ([#787](https://www.github.com/googleapis/java-bigtable/issues/787)) ([#835](https://www.github.com/googleapis/java-bigtable/issues/835)) ([cf16cfe](https://www.github.com/googleapis/java-bigtable/commit/cf16cfe5ee1ec509ed8faf3ff1342bd02a041468)) * improve embedded version handling ([#715](https://www.github.com/googleapis/java-bigtable/issues/715)) ([#832](https://www.github.com/googleapis/java-bigtable/issues/832)) ([f0fc1bf](https://www.github.com/googleapis/java-bigtable/commit/f0fc1bf77962ddc80bfd5aca6a8ca731641d940b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Should be 20 KB not 20 MB
https://cloud.google.com/bigtable/quotas#row-filters