fix: readRowSettings use manual readRows settings instead of gapic's #494
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I found that the
readRowsettings were referencing thebaseDefaults(i.e. the defaults in the GAPIC stub settings) forreadRows, rather than the manually overridden settings that are used for theretryableCodesimmediately above. This seems like the safest thing to keep the sources of the RetrySettings all referencing the manually overridden settings.This will also be necessary for an upcoming config change that will make RPCs configured as non-retryable in the GAPIC to be generated without backoff settings (because they are not retryable). @igorbernstein2 this is the change we spoke about.