Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Conversation

@pmakani
Copy link
Contributor

@pmakani pmakani commented Sep 3, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@pmakani pmakani requested review from a team and stephaniewang526 September 3, 2020 13:04
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #322 +/- ## ========================================= Coverage 74.68% 74.68% Complexity 108 108 ========================================= Files 7 7 Lines 948 948 Branches 18 18 ========================================= Hits 708 708 Misses 220 220 Partials 20 20 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62ee9d...c5b3f09. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 35552a6 into googleapis:master Sep 3, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 3, 2020
@pmakani pmakani deleted the createschedule-query-serviceaccount branch September 4, 2020 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

2 participants