Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Sep 30, 2020

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@stephaniewang526
Copy link
Contributor

Hi @billyjacobson -- PTAL as well! Thank you.

@stephaniewang526 stephaniewang526 marked this pull request as ready for review September 30, 2020 15:55
@stephaniewang526 stephaniewang526 requested a review from a team September 30, 2020 15:55
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #764 +/- ## ========================================= Coverage 80.41% 80.41% Complexity 1265 1265 ========================================= Files 79 79 Lines 6530 6530 Branches 742 743 +1 ========================================= Hits 5251 5251 Misses 889 889 Partials 390 390 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038e55d...4905230. Read the comment docs.

Copy link

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for java-samples

// once, and can be reused for multiple requests.
BigQuery bigquery = BigQueryOptions.getDefaultInstance().getService();

BigtableColumn name =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments from #763 regarding example bigtable schema

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Oct 1, 2020
@pmakani pmakani force-pushed the query-external-bigtable-perm branch from d2cc43b to 4905230 Compare October 7, 2020 05:44
@pmakani
Copy link
Contributor Author

pmakani commented Oct 7, 2020

@stephaniewang526 stephaniewang526 merged commit 257edfc into googleapis:master Oct 7, 2020
@pmakani pmakani deleted the query-external-bigtable-perm branch October 7, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

5 participants