fix: update HttpRequest#getVersion to use stable logic #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The original implementation of `getVersion` used the implementation version of the package of the declaring class, however there is differing behavior between Android and openjdk based jvms. In order to be consistent across platforms we will now always resolve the value from the `google-http-client.properties` file that is generated during the build. This method should be stable as it based on loading a classpath resource which has cross jvm support. Fixes #892
googlebot added the cla: yes 
codyoss approved these changes Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The original implementation of
getVersionused the implementationversion of the package of the declaring class, however there is
differing behavior between Android and openjdk based jvms.
In order to be consistent across platforms we will now always resolve
the value from the
google-http-client.propertiesfile that isgenerated during the build. This method should be stable as it based
on loading a classpath resource which has cross jvm support.
Fixes #892