Skip to content

Conversation

@ngthuongdoan
Copy link

Hey @goldbergyoni, this is the first time I contribute to another repo 🥲. I don't know how to do next.
Currently, I've done some first paragraph on my forked repo. You said that I make a PR, and then what should I do next?
Continue to translate on master branch on my forked or what?

@ngthuongdoan ngthuongdoan changed the title Need help about contributing [Vietnamese Translation] Need help about contributing Apr 3, 2021
@brunopenso
Copy link

HI,

I should continue to contribute in your repo. You can change this PR to a draft, I think is the best option, when you are ready change the PR to active and ask to approval here.

@ngthuongdoan ngthuongdoan marked this pull request as draft April 4, 2021 01:12
@goldbergyoni
Copy link
Owner

@ngthuongdoan Sorry for the late reply, I was on paternity leave. Looks like a great start 🚀!

What we typically do is creating a dedicated branch here for the translation, then your PR should target this branch. I've already created one for you which is called 'translations-draft-vietnamese'. Does this make sense?

You can also work with @brunopenso on your repo and then occasionally save your progress to 'translations-draft-vietnamese'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants