Api extentions: Client #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
repo_commits.go Outdated
There was a problem hiding this comment.
There was a problem hiding this comment.
I think it is better to have a seperation between the webhooks and the commit models. It would be easier to extend them in the future.
And payload author is not exactly the same as a commit signature.
You could have commits from local users that does not have a user on gogs. And payload author lacks the when field.
What do you think?
guyzmo pushed a commit to guyzmo/go-gogs-client that referenced this pull request May 5, 2017
More drone requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This comes together with a pull request on Gogs. (Api extentions: Server)