Additional API support for Labels #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I think you can just put all your changes in |
lstahlman force-pushed the api-label-support branch from 24f8c13 to d93f62e Compare | Done |
issue_label.go Outdated
| } | ||
| label := new(Label) | ||
| return label, c.getParsedResponse("POST", fmt.Sprintf("/repos/%s/%s/labels", owner, repo), | ||
| http.Header{"content-type": []string{"application/json"}}, bytes.NewReader(body), label) |
There was a problem hiding this comment.
You can use jsonHeader to replace http.Header{"content-type": []string{"application/json"}}.
There was a problem hiding this comment.
That's a cleaner way to do it. Updated.
lstahlman force-pushed the api-label-support branch 3 times, most recently from 2864f8d to 7cbbdce Compare lstahlman force-pushed the api-label-support branch from 7cbbdce to 5f159d0 Compare | Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implements the ability to manage repository labels and an issue's labels via the API.
As a part of adding support, the Labels struct was moved to label.go and an ID field was added to it.