API extensions #12
API extensions #12
Conversation
There was a problem hiding this comment.
What does this struct do? Seems not using it anywhere?
There was a problem hiding this comment.
Oh. I didn't create the client method in the gogs client.
The DiffFile struct is used in gogs.
I tested the service method from the java lib and forgot the client method in gogs-client
There was a problem hiding this comment.
OK... should you remove it or...?
There was a problem hiding this comment.
No. It is used by Gogs, and is needed for my gogs pull request. See the DiffRange function in the that pull request.
This is also why the gogs pull request has dependency to kiliit/go-gogs-client. If it hasn't then compile fails.
There was a problem hiding this comment.
Sorry I don't get it...
Gogs has these structs itself, why need import from this package?
| Hi, can you resolve conflicts? |
WIP: fix most of all the lint errors
2 participants
Some extensions of the api