feat: add validator for IPv4 bind address / host:port #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
supporting older Golang versions by using net.ParseIP, not netip.ParseAddr
rtomadpg force-pushed the feat-add-ipv4port branch from 9597b0f to e022a95 Compare 
nodivbyzero reviewed Dec 10, 2024
Co-authored-by: nodivbyzero <nodivbyzero@gmail.com>
alob-mtc reviewed Jul 15, 2025
| return false | ||
| } | ||
| // Validate port range (1-65535). | ||
| if portNum, err := strconv.ParseUInt(port, 10, 32,); err != nil || portNum < 1 || portNum > 65535 { |
There was a problem hiding this comment.
Suggested change
| if portNum, err := strconv.ParseUInt(port, 10, 32,); err != nil || portNum < 1 || portNum > 65535 { | |
| if portNum, err := strconv.ParseUint(port, 10, 32); err != nil || portNum < 1 || portNum > 65535 { |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Here is a little PR to say thank you, for providing your framework.
Let's add a validator for IPv4 bind addresses.
Examples of valid input:
:9000for port 9000 on any IP address1.2.3.4:7777for port 7777 on specific IP addressMy use case: I need this validator for an application's config including IP based socket listener addresses, like:
:9999or127.0.0.1:9999Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers