Handle OAuth responses as querystring as well as JSON on Android #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
(x-www-form-urlencoded), not as JSON, so signing in breaks as per fullstackreact#165. Correct this by catching the JSON parse error and falling back to extracting the parameters we need from the token instead.
Merge in OAuthManager.h iOS fixes
SailingSteve added a commit to SailingSteve/react-native-oauth that referenced this pull request Oct 25, 2017
and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
SailingSteve added a commit to SailingSteve/react-native-oauth that referenced this pull request Oct 25, 2017
and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
SailingSteve added a commit to SailingSteve/react-native-oauth that referenced this pull request Oct 26, 2017
and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
shalin-jasani added a commit to shalin-jasani/react-native-oauth that referenced this pull request Sep 10, 2018
…ani/fullstackreact/react-native-oauth master branch (#1) * Added fullstackreact#171 and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m * Added fullstackreact#171 and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m * Added fullstackreact#171 and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m * Merge PR 121, fix user agent, fix full screen webview * Changed if/else statement to avoid React error. * Fix duplicate RCTMethodInfo import (facebook/react-native#15775) (zoontek/react-native-permissions#137) * Fix duplicate React library import error conflict w/certain pods * Pass back response headers over javascript bridge * Dispatch safariViewController on main queue The safariViewController dispatch was occuring on another thread. This sometimes caused app crashes when the view was presented, in particular if the keyboard had been presented via a TextInput or other component. The resulting crash complained about _cachedSystemAnimationFence and the main thread. This has been with other React Native apps that load a viewController. Dispatching to present the viewController on the main thread fixes this issue. * Fix build issue * Remove deprecated @OverRide * Fix: Duplicate RCTMethodInfo while building iOS app * Fix error for redefinition of RCTMethodInfo * Ignored dist/ * 2.1.16 * 2.1.17 * 2.1.18
dionsake added a commit to dionsake/workspace-react-native-OAuth that referenced this pull request Jan 10, 2020
and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
dionsake added a commit to dionsake/workspace-react-native-OAuth that referenced this pull request Jan 10, 2020
and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
dionsake added a commit to dionsake/workspace-react-native-OAuth that referenced this pull request Jan 10, 2020
and my NSString *clientID fix, which might not be as good as https://github.com/fullstackreact/react-native-oauth/blob/2f8c8d1483526bbc8a6ca72183c6d11a71538ad3/ios/OAuthManager/OAuthManager.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Twitter, for example, returns OAuth token data as a querystring (x-www-form-urlencoded), not as JSON, so signing in breaks as per #165.
Correct this by catching the JSON parse error and falling back to extracting the parameters we need from the token instead.