Skip to content

fix for issue 69, missing downloadUrl property from file upload response on iOS #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2016
Merged

fix for issue 69, missing downloadUrl property from file upload response on iOS #148

merged 2 commits into from
Nov 18, 2016

Conversation

@tegument
Copy link

@tegument tegument commented Nov 18, 2016

Fix for issue #69
@tegument tegument mentioned this pull request Nov 18, 2016
Open
auser
auser reviewed Nov 18, 2016
View reviewed changes
Copy link
Contributor

@auser auser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we always know it'll be the first of those urls?

Think we should update the response to include all this urls in the response?
@tegument
Copy link
Author

tegument commented Nov 18, 2016

I've never seen more than one, so not sure. I know android always has just the URL as the downloadUrl property, but in the metadata it will show an array for downloadUrls.
@auser auser merged commit fba26f8 into fullstackreact:master Nov 18, 2016
@tegument
Copy link
Author

tegument commented Nov 18, 2016

JS documentation shows:

// Upload completed successfully, now we can get the download URL
var downloadURL = uploadTask.snapshot.downloadURL;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@tegument @auser