Rule to blacklist / prohibit certain file name patterns. #11
Conversation
| @florianehmke Thanks for the new rule! It's a greate idea! |
lib/rules/filename-blacklist.js Outdated
| }, | ||
| { | ||
| type: 'object', | ||
| }, |
There was a problem hiding this comment.
Since this new rule does not need the rule configuration object, I think { type: 'object', } is unnecessary.
lib/rules/filename-blacklist.js Outdated
| | ||
| if (useInsteadPattern) { | ||
| message += ' Use a pattern like {{ useInsteadPattern }} instead.'; | ||
| } |
There was a problem hiding this comment.
I think ' Use a pattern like "{{ useInsteadPattern }}" instead.' will be better.
lib/utils/match.js Outdated
| pattern: blackListPattern, | ||
| }; | ||
| }; | ||
| |
There was a problem hiding this comment.
I think you can reuse the matchRule method with some changes to the params targetNaming and targetNamingPattern, just making them optional.
lib/rules/filename-blacklist.js Outdated
| let message = | ||
| 'The filename "{{path}}" matches the blacklisted "{{pattern}}" pattern.'; | ||
| | ||
| if (useInsteadPattern) { |
There was a problem hiding this comment.
It seems useInsteadPattern is always given, I do not think it is necessary to protect it with if.
| @florianehmke This PR is merged. This will be released over the weekend. Thanks! |
| Thanks alot! |
| The PR has been released in version 1.3.0. Thanks! |
4 participants
This PR adds a new rule to prohibit certain file name patterns.
I think this is a good addition to this plugin. I often see inconsistent usage of file patterns like the ones used in the tests. Instead of documenting such things I want an eslint rule that takes care of that for me.
Let me know what you think and if I should change something.