Implement Request::getBasicCredentials for http basic auth testing #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`getBasicCredentials` method is implemented in Nette\Http\Request, but it's not part of IRequest interface, so it was missing in this Codeception\Http\Request implementation. With this change we can use `$this->tester->amHttpAuthenticated()`.
| Thanks |
| Could you please consider creating a new patch release of the composer package? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
getBasicCredentialsmethod is implemented in Nette\Http\Request, but it's not part of IRequest interface, so it was missing in this Codeception\Http\Request implementation. With this change we can use$this->tester->amHttpAuthenticated().Implemented using
method_exists($this->request, 'getBasicCredentials')so it's more universal, not depending directly toNette\Http\Request.