Fix netteConnector with phpunit10 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4351254014
💛 - Coveralls |
| possible to tag a release please @f3l1x ? |
| Sure, pls don't rush. :-) https://github.com/contributte/codeception/releases/tag/v1.4.2 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Because of https://github.com/sebastianbergmann/phpunit/blob/main/src/TextUI/Configuration/Merger.php#L102, phpunit relies on
$_SERVER['PHP_SELF']. It works fine when there's just one suite. But when there are more, the 2nd suite would fail on the line above because$_SERVER['PHP_SELF']would be null andrealpath()does not accept null.Perhaps there is a "nicer" solution but this PR fixes the issue I was having completely.
If merged, please tag a new release if at all possible.