Skip to content

test: Update requirements.txt #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test: Update requirements.txt #159

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1db0599
test: Update requirements.txt
shenxianpeng Nov 5, 2025
0145c66
fix: Update requirements.txt
shenxianpeng Nov 5, 2025
f0e71ef
test: Update action.yml
shenxianpeng Nov 5, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: Update action.yml
  • Loading branch information
@shenxianpeng
shenxianpeng authored Nov 5, 2025
commit f0e71efe5dee5c81367193aa7f5b24de6070cdd8
13 changes: 2 additions & 11 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,8 @@ runs:
python3 -m venv venv
source venv/bin/activate

# Download artifact
python3 -m pip download -r "$GITHUB_ACTION_PATH/requirements.txt"

# Verify artifact attestations
if ! gh attestation verify commit_check-*.whl -R commit-check/commit-check; then
echo "Artifact verification failed. Aborting installation."
exit 1
fi

# Install artifact
python3 -m pip install commit_check-*.whl pygithub-*.whl
# Install artifacts
python3 -m pip install -r "$GITHUB_ACTION_PATH/requirements.txt"
Comment on lines +51 to +52
Copy link

@coderabbitai coderabbitai bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Update misleading comment on line 51.

The comment says "Install artifacts" but the code now installs from requirements.txt. Update for clarity:

- # Install artifacts + # Install dependencies from requirements.txt python3 -m pip install -r "$GITHUB_ACTION_PATH/requirements.txt"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Install artifacts
python3 -m pip install -r "$GITHUB_ACTION_PATH/requirements.txt"
# Install dependencies from requirements.txt
python3 -m pip install -r "$GITHUB_ACTION_PATH/requirements.txt"
🤖 Prompt for AI Agents 
In action.yml around lines 51 to 52, the inline comment "Install artifacts" is now misleading because the step installs Python packages from requirements.txt; update the comment to clearly reflect the action (e.g., "Install Python dependencies from requirements.txt") so it matches the pip install command and improves readability.

python3 "$GITHUB_ACTION_PATH/main.py"
env:
Expand Down
Loading