Pull request for 10 rules ESS-ENN #5
no-null-cipher-java
- Loading branch information
commit e7b4680ecd928296e4d4d405aea7a4dbffd952bb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| id: no-null-cipher-java | ||
| severity: warning | ||
| language: java | ||
| message: >- | ||
| NullCipher was detected. This will not encrypt anything; the cipher | ||
| text will be the same as the plain text. Use a valid, secure cipher: | ||
| Cipher.getInstance("AES/CBC/PKCS7PADDING"). See | ||
| https://owasp.org/www-community/Using_the_Java_Cryptographic_Extensions | ||
| for more information. | ||
| note: >- | ||
| [CWE-327] Use of a Broken or Risky Cryptographic Algorithm. | ||
| [REFERENCES] | ||
| - https://owasp.org/Top10/A02_2021-Cryptographic_Failures | ||
| rule: | ||
| any: | ||
| - pattern: new NullCipher($$$) | ||
| - pattern: new javax.crypto.NullCipher($$$) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| id: no-null-cipher-java | ||
| snapshots: | ||
| ? |- | ||
| Cipher doNothingCihper = new NullCipher(); | ||
| new javax.crypto.NullCipher(); | ||
| : labels: | ||
| - source: new NullCipher() | ||
| style: primary | ||
| start: 25 | ||
| end: 41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| id: no-null-cipher-java | ||
| valid: | ||
| - | | ||
| Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding"); | ||
| invalid: | ||
| - | | ||
| Cipher doNothingCihper = new NullCipher(); | ||
| new javax.crypto.NullCipher(); | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Cases Correctly Demonstrated
The test cases are well-formed:
Static Analysis Hint: Missing New Line at End of File
To comply with YAML standards and static analysis tools, add a newline at the end of the file. This can be fixed by ensuring your text editor is configured to automatically add new lines at the end of files or by manually adding a newline.
+Committable suggestion
Tools
yamllint