Skip to content

fix: semantic issue in 14-profile-status #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: semantic issue in 14-profile-status #29

merged 2 commits into from
Oct 30, 2023

Conversation

@madebysergio
Copy link

This PR closes a repetitive issue in #27.
@madebysergio madebysergio changed the title feat: wrap h3 in a list-item fix: semantic issue in 14-profile-status Oct 30, 2023
@Dusch4593
Copy link
Contributor

Dusch4593 commented Oct 30, 2023 •
edited
Loading

Hey @beingsie! Thank you so much for flagging this!

You are correct about how heading elements (<h1> - <h6>) should be directly placed inside a <ul> unordered list element. Before we merge this PR, might suggest the following change:

<h2>My Feed</h2> <ul id="post-list">

Since this header is meant to represent all of the list items inside of the <ul>, I think it makes more sense to move it out of the <ul> (rather than make it a list item like you did in your change).

Let me know when you've made this change and I'll be happy to merge! 😄
@Dusch4593 Dusch4593 linked an issue Oct 30, 2023 that may be closed by this pull request
Improper Use of <h2> Tag Inside <ul> Element #27
Closed
Dusch4593
Dusch4593 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @beingsie! Since we're past the cutoff time for our monthly challenge, I went ahead and made this change so we can merge this PR! 🚀
@Dusch4593 Dusch4593 merged commit 8e27d71 into codedex-io:main Oct 30, 2023
@sonnynomnom sonnynomnom added the bug hunter challenge www.codedex.io/community/monthly-challenge/october-2023 label Oct 31, 2023
@madebysergio madebysergio deleted the fix/#27-in-14-profile-status branch November 1, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug hunter challenge www.codedex.io/community/monthly-challenge/october-2023

3 participants

@madebysergio @Dusch4593 @sonnynomnom