Skip to content

Conversation

@madebysergio
Copy link

Fix: Improper use of h3 tag inside ul

  • This PR fixes an improper use of an h3 tag inside a ul tag.

Changes:

  • h3 tag has been wrapped inside of a li tag.
    • Note: The CSS removes the user list style added after wrapping the h3 tag in a li tag.

Related issues:

@madebysergio madebysergio changed the title fix: improper use of h3 tag inside user list fix: semantic issue in 17-make-it-count Oct 30, 2023
@Dusch4593
Copy link
Contributor

Hey @beingsie! Thank you so much for flagging this!

You are correct about how heading elements (<h1> - <h6>) should be directly placed inside a <ul> unordered list element. Before we merge this PR, might suggest the following change:

<h2>My Feed</h2> <ul id="post-list">

Since this header is meant to represent all of the list items inside of the <ul>, I think it makes more sense to move it out of the <ul> (rather than make it a list item like you did in your change).

Let me know when you've made this change and I'll be happy to merge! 😄

Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @beingsie! Since we're past the cutoff time for our monthly challenge, I went ahead and made this change so we can merge this PR! 🚀

@Dusch4593 Dusch4593 merged commit 2a380ae into codedex-io:main Oct 30, 2023
@sonnynomnom sonnynomnom added the bug hunter challenge www.codedex.io/community/monthly-challenge/october-2023 label Oct 31, 2023
@madebysergio madebysergio deleted the fix/improper-use-of-h3-#27 branch November 1, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug hunter challenge www.codedex.io/community/monthly-challenge/october-2023

3 participants