Skip to content

fix: add missing border properties #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: add missing border properties #26

merged 1 commit into from
Oct 30, 2023

Conversation

@madebysergio
Copy link

@madebysergio madebysergio commented Oct 29, 2023 •
edited
Loading

Fix: Add missing border properties

  • This PR fixes a bug that occurs from two missing border properties, style and color.

Changes:

  • Added border properties style and color to #catalog-input and .staff-pick-img.

Expected behavior:

  • Both input for searching the catalog and the staff pick images properly display their borders.

After changes:

image

Before changes:

image

Related issues:
Dusch4593
Dusch4593 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, @beingsie! Merging this now. 😄
@Dusch4593 Dusch4593 merged commit a56d64f into codedex-io:main Oct 30, 2023
@sonnynomnom sonnynomnom added the bug hunter challenge www.codedex.io/community/monthly-challenge/october-2023 label Oct 31, 2023
@madebysergio madebysergio deleted the fix/missing-border-properties-#25 branch November 1, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug hunter challenge www.codedex.io/community/monthly-challenge/october-2023

3 participants

@madebysergio @Dusch4593 @sonnynomnom