Skip to content

Fix/double identical id names#21 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix/double identical id names#21 #22

merged 2 commits into from
Oct 30, 2023

Conversation

@madebysergio
Copy link

Fix: Double identical ID attribute names

  • This PR adds 2 fixes to both the index.html and styles.css.

Changes

  • Removed a second identical ID attribute name found in index.html, as the ID attribute must be unique within a document.
  • To accommodate this change I have added the required padding initially intended for the H1 tag to have. This keeps the initial styling of index.html the same while addressing the identical ID attribute name found in index.html.

Related issues:
@Dusch4593
Copy link
Contributor

Looks good to merge, @beingsie! Thank you for flagging this! 👍🏻
@Dusch4593 Dusch4593 merged commit a6edc0a into codedex-io:main Oct 30, 2023
@sonnynomnom sonnynomnom added the bug hunter challenge www.codedex.io/community/monthly-challenge/october-2023 label Oct 31, 2023
@madebysergio madebysergio deleted the fix/double-identical-id-names#21 branch November 1, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug hunter challenge www.codedex.io/community/monthly-challenge/october-2023

3 participants

@madebysergio @Dusch4593 @sonnynomnom