feat(testcafe): add the support for testcafe #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks a lot for your help with this @guiyomh, this will be reviewed and merged soon. |
puneet0191 requested changes Apr 15, 2020
| let location, size; | ||
| | ||
| if (this.helpers['Puppeteer']) { | ||
| const el = els[0]; |
There was a problem hiding this comment.
I moved this assignment from line 373 here. Because that doesn't work like this for TestCafe.
| } | ||
| | ||
| if (this.helpers['WebDriver'] || this.helpers['Appium']) { | ||
| const el = els[0]; |
There was a problem hiding this comment.
yes for the same reason. I didn't like this duplicate of code. But If you have a better solution, I'm ready to implement it.
| @DavertMik could we merge this one? |
| @jonatask help me with some testing for this? |
puneet0191 added a commit that referenced this pull request May 16, 2020
* Issue #60 - Prepare all baselines of test by setting parameter in config (#65) Co-authored-by: Jonatas Kirsch <jonatas.kirsch@takeaway.com> * Update Dependecies, Fix Fatal Error with mkdirp and Mac (#66) * Update Dependencies * Fix Error on Mac * Avoid failing the test for a given threshold but yet generating the difference image (#63) * Option bypassFailure allowing the user to avoid failing the test for a given threshold but yet generating the difference image * Renamed option to skipFailure Co-authored-by: Jonatas Kirsch <jonatas.kirsch@takeaway.com> * feat(testcafe): add the support for testcafe (#62) * passing through output settings to resemble.js (#59) Co-authored-by: JANK Michael <Michael.JANK@cns-solutions.net> * Issue 48 - Add custom assert message (#64) Co-authored-by: Jonatas Kirsch <jonatas.kirsch@takeaway.com> Co-authored-by: Jonatas Kirsch <jonataskirsch@gmail.com> Co-authored-by: Jonatas Kirsch <jonatas.kirsch@takeaway.com> Co-authored-by: Guillaume Camus <guiyomh@users.noreply.github.com> Co-authored-by: yankydoo <yankydoo@users.noreply.github.com> Co-authored-by: JANK Michael <Michael.JANK@cns-solutions.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adding the support of TestCafe