Make the rust portion more modular #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| Note: UnsafeCell use was because optimizer kept removing the export randomly for some reason. I have Copy restriction because I made a method to get a copy of the slice... but I ended up not using it. |
Member Author
| Also, I got the ownership of https://crates.io/crates/tiny-secp256k1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This splits up the rust portion into two crates:
This will allow others to make use of the main library.
I would like to add doc examples and maybe doc-tests in the main library and then publish to crates.io... but we'll see.
It looks like tiny-secp256k1 on crates.io is taken, but it is not being used. Maybe @maciejhirsz would like to give it to us? (Please?)
I also switched the release profile to opt-level "z" which gives a 66% reduction in binary size, but we get a 5~10% hit to performance.