Skip to content

Feature/stream transactions #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Aug 14, 2019
Merged

Feature/stream transactions #292

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6bff809
beginStreamTransaction
Aug 6, 2019
d360707
abortStreamTransaction
Aug 6, 2019
0ad5c32
differentiated tests for aborting invalidTransactionId and notExistin…
Aug 7, 2019
939758c
getStreamTransaction
Aug 7, 2019
4c8da6c
formatted code adopting project formatter
Aug 7, 2019
ffa0a6c
requireVersion 3.5 for Stream Transaction tests
Aug 7, 2019
dfa10a0
commitStreamTransaction
Aug 7, 2019
7b8eae6
bugfix requireVersion using assumeTrue
Aug 8, 2019
f854b88
ArangoDatabase::getEngine
Aug 8, 2019
0f72d26
requireStorageEngine rocksdb for stream transaction tests
Aug 8, 2019
642fd23
stream transactions extension for document and collection APIs
Aug 8, 2019
57abb54
test commitStreamTransactionTwice and abortStreamTransactionTwice
Aug 8, 2019
cdd67b6
Stream Transactions collections operations test
Aug 8, 2019
3999b57
stream transactions: replaceDocument & replaceDocuments test
Aug 9, 2019
78c510c
stream transactions: test
Aug 12, 2019
c2b6c6a
stream transactions: test
Aug 12, 2019
21bb9a9
stream transactions: Cursors
Aug 12, 2019
d472431
authorship comments
Aug 12, 2019
9f1999d
stream transactions: moved all tests together
Aug 12, 2019
d723612
@since comments
Aug 12, 2019
61a29e8
ConcurrentStreamTransactionsTest
Aug 12, 2019
89ad4f5
stream transactions: skip tests for cluster environments
Aug 13, 2019
a0cd1d4
stream transactions: test operation with invalid tx id
Aug 13, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bugfix requireVersion using assumeTrue
  • Loading branch information
michele committed Aug 8, 2019
commit 7b8eae6314b829d2c88d2739e7058360fa5f7c45
53 changes: 14 additions & 39 deletions src/test/java/com/arangodb/ArangoDatabaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import static org.hamcrest.CoreMatchers.nullValue;
import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;
import static org.junit.Assume.assumeTrue;

/**
* @author Mark Vollmary
Expand Down Expand Up @@ -1409,9 +1410,7 @@ public void transactionPojoReturn() {

@Test
public void beginStreamTransaction() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
StreamTransactionEntity tx = db.beginStreamTransaction(null);
assertThat(tx.getId(), is(notNullValue()));
assertThat(tx.getStatus(), is(StreamTransactionEntity.StreamTransactionStatus.running));
Expand All @@ -1420,17 +1419,13 @@ public void beginStreamTransaction() {

@Test(expected = ArangoDBException.class)
public void beginStreamTransactionWithNonExistingCollectionsShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
db.beginStreamTransaction(new StreamTransactionOptions().writeCollections("notExistingCollection"));
}

@Test
public void abortStreamTransaction() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
StreamTransactionEntity begunTx = db.beginStreamTransaction(null);
StreamTransactionEntity abortedTx = db.abortStreamTransaction(begunTx.getId());
assertThat(abortedTx.getId(), is(notNullValue()));
Expand All @@ -1440,35 +1435,27 @@ public void abortStreamTransaction() {

@Test(expected = ArangoDBException.class)
public void abortStreamTransactionWhenTransactionIdDoesNotExistsShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
db.abortStreamTransaction("000000");
}

@Test(expected = ArangoDBException.class)
public void abortStreamTransactionWithInvalidTransactionIdShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
db.abortStreamTransaction("invalidTransactionId");
}

@Test(expected = ArangoDBException.class)
public void abortCommittedStreamTransactionShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
StreamTransactionEntity createdTx = db.beginStreamTransaction(null);
db.commitStreamTransaction(createdTx.getId());
db.abortStreamTransaction(createdTx.getId());
}

@Test
public void getStreamTransaction() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
StreamTransactionEntity createdTx = db.beginStreamTransaction(null);
StreamTransactionEntity gotTx = db.getStreamTransaction(createdTx.getId());
assertThat(gotTx.getId(), is(notNullValue()));
Expand All @@ -1479,25 +1466,19 @@ public void getStreamTransaction() {

@Test(expected = ArangoDBException.class)
public void getStreamTransactionWhenTransactionIdDoesNotExistsShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
db.getStreamTransaction("000000");
}

@Test(expected = ArangoDBException.class)
public void getStreamTransactionWithInvalidTransactionIdShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
db.getStreamTransaction("invalidTransactionId");
}

@Test
public void commitStreamTransaction() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
StreamTransactionEntity createdTx = db.beginStreamTransaction(null);
StreamTransactionEntity committedTx = db.commitStreamTransaction(createdTx.getId());
assertThat(committedTx.getId(), is(notNullValue()));
Expand All @@ -1507,25 +1488,19 @@ public void commitStreamTransaction() {

@Test(expected = ArangoDBException.class)
public void commitStreamTransactionWhenTransactionIdDoesNotExistsShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
db.commitStreamTransaction("000000");
}

@Test(expected = ArangoDBException.class)
public void commitStreamTransactionWithInvalidTransactionIdShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
db.commitStreamTransaction("invalidTransactionId");
}

@Test(expected = ArangoDBException.class)
public void commitAbortedStreamTransactionShouldThrow() {
if (!requireVersion(3, 5)) {
return;
}
assumeTrue(requireVersion(3, 5));
StreamTransactionEntity createdTx = db.beginStreamTransaction(null);
db.abortStreamTransaction(createdTx.getId());
db.commitStreamTransaction(createdTx.getId());
Expand Down