Skip to content

Add Override ToString in Response #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neiesc wants to merge 1 commit into from
Closed

Add Override ToString in Response #35

neiesc wants to merge 1 commit into from

Conversation

@neiesc
Copy link

@neiesc neiesc commented Oct 6, 2020 •
edited
Loading

I'm would be adding unit tests for this too, what do you think @andrei-m-code ? What tests runner you be like xunit, nunit?
@enisn
Copy link

enisn commented Nov 10, 2020

Looks better while debugging
@neiesc
Copy link
Author

neiesc commented Nov 10, 2020 •
edited
Loading

I use for logs like:
_logger.LogDebug($"Response from apn: {JsonConvert.SerializeObject(response)}"); nowadays.
@andrei-m-code
Copy link
Owner

andrei-m-code commented Nov 10, 2020

Yea I'm not sure if this ToString() override is necessary. Most likely we'll change those classes to records and ToString() will be printing record properties. So I'd skip this PR for now. @enisn @neiesc

Thanks though. It's not a bad idea anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@neiesc @enisn @andrei-m-code