CHANGE: Deprecate useIMGUIEditorForAssets #2283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
K-Tone changed the title ![u-pr-agent[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Comment on lines 215 to 224
| private const string tolltip = "Determine which axis 'wins' if both are actuated at the same time. " | ||
| + "If 'Neither' is selected, the result is 0 (or, more precisely, " | ||
| + "the midpoint between minValue and maxValue)."); | ||
| | ||
| public override void OnGUI() | ||
| { | ||
| if (!InputSystem.settings.useIMGUIEditorForAssets) | ||
| return; | ||
| | ||
| target.whichSideWins = (AxisComposite.WhichSideWins)EditorGUILayout.EnumPopup(m_WhichAxisWinsLabel, target.whichSideWins); | ||
| } | ||
| + "the midpoint between minValue and maxValue)."; | ||
| | ||
| public override void OnDrawVisualElements(VisualElement root, Action onChangedCallback) | ||
| { | ||
| var modeField = new EnumField(m_WhichAxisWinsLabel.text, target.whichSideWins) | ||
| var modeField = new EnumField(label, target.whichSideWins) | ||
| { | ||
| tooltip = m_WhichAxisWinsLabel.tooltip | ||
| tooltip = tolltip | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggestion: The constant name tolltip contains a typo. It should be corrected to tooltip. For better clarity and to avoid confusion with the VisualElement.tooltip property, consider renaming it to tooltipText. [general, importance: 6]
Suggested change
| private const string tolltip = "Determine which axis 'wins' if both are actuated at the same time. " | |
| + "If 'Neither' is selected, the result is 0 (or, more precisely, " | |
| + "the midpoint between minValue and maxValue)."); | |
| public override void OnGUI() | |
| { | |
| if (!InputSystem.settings.useIMGUIEditorForAssets) | |
| return; | |
| target.whichSideWins = (AxisComposite.WhichSideWins)EditorGUILayout.EnumPopup(m_WhichAxisWinsLabel, target.whichSideWins); | |
| } | |
| + "the midpoint between minValue and maxValue)."; | |
| public override void OnDrawVisualElements(VisualElement root, Action onChangedCallback) | |
| { | |
| var modeField = new EnumField(m_WhichAxisWinsLabel.text, target.whichSideWins) | |
| var modeField = new EnumField(label, target.whichSideWins) | |
| { | |
| tooltip = m_WhichAxisWinsLabel.tooltip | |
| tooltip = tolltip | |
| }; | |
| private const string tooltipText = "Determine which axis 'wins' if both are actuated at the same time. " | |
| + "If 'Neither' is selected, the result is 0 (or, more precisely, " | |
| + "the midpoint between minValue and maxValue)."; | |
| public override void OnDrawVisualElements(VisualElement root, Action onChangedCallback) | |
| { | |
| var modeField = new EnumField(label, target.whichSideWins) | |
| { | |
| tooltip = tooltipText | |
| }; |
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent
Comment on lines +195 to 204
| private const string tooltip = "How to synthesize a Vector2 from the inputs. Digital " | ||
| + "treats part bindings as buttons (on/off) whereas Analog preserves " | ||
| + "floating-point magnitudes as read from controls."); | ||
| | ||
| public override void OnGUI() | ||
| { | ||
| if (!InputSystem.settings.useIMGUIEditorForAssets) | ||
| return; | ||
| | ||
| target.mode = (Vector2Composite.Mode)EditorGUILayout.EnumPopup(m_ModeLabel, target.mode); | ||
| } | ||
| + "floating-point magnitudes as read from controls."; | ||
| | ||
| public override void OnDrawVisualElements(VisualElement root, Action onChangedCallback) | ||
| { | ||
| var modeField = new EnumField(m_ModeLabel.text, target.mode) | ||
| var modeField = new EnumField(label, target.mode) | ||
| { | ||
| tooltip = m_ModeLabel.tooltip | ||
| tooltip = tooltip | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggestion: The assignment tooltip = tooltip is confusing as it relies on C# scoping rules to differentiate between the class constant and the VisualElement property. To improve readability and consistency with other parts of the PR, rename the tooltip constant to tooltipText. [general, importance: 6]
Suggested change
| private const string tooltip = "How to synthesize a Vector2 from the inputs. Digital " | |
| + "treats part bindings as buttons (on/off) whereas Analog preserves " | |
| + "floating-point magnitudes as read from controls."); | |
| public override void OnGUI() | |
| { | |
| if (!InputSystem.settings.useIMGUIEditorForAssets) | |
| return; | |
| target.mode = (Vector2Composite.Mode)EditorGUILayout.EnumPopup(m_ModeLabel, target.mode); | |
| } | |
| + "floating-point magnitudes as read from controls."; | |
| public override void OnDrawVisualElements(VisualElement root, Action onChangedCallback) | |
| { | |
| var modeField = new EnumField(m_ModeLabel.text, target.mode) | |
| var modeField = new EnumField(label, target.mode) | |
| { | |
| tooltip = m_ModeLabel.tooltip | |
| tooltip = tooltip | |
| }; | |
| private const string tooltipText = "How to synthesize a Vector2 from the inputs. Digital " | |
| + "treats part bindings as buttons (on/off) whereas Analog preserves " | |
| + "floating-point magnitudes as read from controls."; | |
| public override void OnDrawVisualElements(VisualElement root, Action onChangedCallback) | |
| { | |
| var modeField = new EnumField(label, target.mode) | |
| { | |
| tooltip = tooltipText | |
| }; |
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Please fill this section with a description what the pull request is trying to address and what changes were made.
Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.