CHANGE: Auto-save on focus lost can no longer be compiled out #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
K-Tone changed the title 
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
Collaborator Author
| CC @Pauliusd01 - here is some more cleanup, no functionality changed hopefully. Do you want to be a reviewer or is it enough to have you mentioned for viz? |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@ ## develop #2282 +/- ## =========================================== + Coverage 76.81% 76.83% +0.01% =========================================== Files 476 476 Lines 88726 88831 +105 =========================================== + Hits 68155 68251 +96 - Misses 20571 20580 +9 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Here we remove the
UNITY_INPUT_SYSTEM_INPUT_ACTIONS_EDITOR_AUTO_SAVE_ON_FOCUS_LOSTcompile time define that theoretically allowed to have the Input package to be compiled without this feature but instead have it save on every change in the editor windows. The define has been set by default for a while so we're confident it's time to remove this bit of variability.Testing status & QA
Local compilation
Overall Product Risks
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.