Skip to content

Conversation

@DEVANSH-GAJJAR
Copy link

@DEVANSH-GAJJAR DEVANSH-GAJJAR commented Jul 31, 2025

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.05%. Comparing base (24f4090) to head (eb1c112).

Files with missing lines Patch % Lines
src/main/java/com/thealgorithms/maths/Volume.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #6453 +/- ## ============================================ + Coverage 75.04% 75.05% +0.01%  - Complexity 5534 5535 +1  ============================================ Files 685 685 Lines 19208 19209 +1 Branches 3706 3706 ============================================ + Hits 14414 14417 +3  Misses 4239 4239 + Partials 555 553 -2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@DenizAltunkapan
Copy link
Member

@DEVANSH-GAJJAR please fix the failing workflows

Copy link
Author

@DEVANSH-GAJJAR DEVANSH-GAJJAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes , I hope i am on the right path

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the failing build and clang format worklfow @DEVANSH-GAJJAR

return (Math.PI * height / 3) * (r1 * r1 + r2 * r2 + r1 * r2);
}

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not indented correctly (compare with other methods)

@DenizAltunkapan
Copy link
Member

@DEVANSH-GAJJAR are you still working on it? If yes, please reopen this pr and fix the failing checks.

@DEVANSH-GAJJAR DEVANSH-GAJJAR deleted the feature/Volume branch August 25, 2025 06:35
@DEVANSH-GAJJAR DEVANSH-GAJJAR restored the feature/Volume branch August 25, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants