Added a few tests for the FibonacciSeries recursive algorithm #6124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BILLSARAN requested review from BamaCharanChhandogi, alxkm, siriak, vil02 and yanglbme as code owners 
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #6124 +/- ## ============================================ - Coverage 73.78% 73.72% -0.07% Complexity 5119 5119 ============================================ Files 658 659 +1 Lines 17632 17650 +18 Branches 3391 3397 +6 ============================================ + Hits 13010 13012 +2 - Misses 4118 4135 +17 + Partials 504 503 -1 ☔ View full report in Codecov by Sentry. |
vil02 requested changes Jan 11, 2025
src/test/java/com/thealgorithms/recursion/FibonacciSeriesTest.java Outdated Show resolved Hide resolved
Comment on lines 24 to +30
| assertEquals(144, FibonacciSeries.fibonacci(12)); | ||
| assertEquals(233, FibonacciSeries.fibonacci(13)); | ||
| assertEquals(377, FibonacciSeries.fibonacci(14)); | ||
| assertEquals(610, FibonacciSeries.fibonacci(15)); | ||
| assertEquals(6765, FibonacciSeries.fibonacci(20)); | ||
| assertEquals(75025, FibonacciSeries.fibonacci(25)); | ||
| assertEquals(832040, FibonacciSeries.fibonacci(30)); |
There was a problem hiding this comment.
I think we reached the point when one should express these are parametrized tests. Perhaps even for all Fibonacci sequence implementations. An example to look at is NumberOfDigitsTest.java.
| 2899fbc - please split this into another pull-request! |
I'm just starting in open source, I would really appreciate it if you could show me how to split into another pull request because I'm kinda lost xD |
…java Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java