Skip to content

Conversation

@preritasaini1
Copy link

@preritasaini1 preritasaini1 commented Oct 28, 2024

Updated the Pangram.java file by adding a bitwise approach and improving code readability

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java
Updated the Pangram.java file by adding a bitwise approach and improving code readability
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (e94be71) to head (6d0d701).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...c/main/java/com/thealgorithms/strings/Pangram.java 45.00% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #6048 +/- ## ============================================ - Coverage 72.42% 72.37% -0.06%  + Complexity 4991 4990 -1  ============================================ Files 655 655 Lines 17593 17602 +9 Branches 3388 3392 +4 ============================================ - Hits 12742 12739 -3  - Misses 4371 4381 +10  - Partials 480 482 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@preritasaini1
Copy link
Author

Hello everyone, I am ne in this contributing world, just checking in on my pull request. I'm excited to learn from your feedback and improve my contributions. Thanks!

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace main with JUnit tests

Copy link
Author

@preritasaini1 preritasaini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced main with JUnit tests. Please check and review . Thanks!

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now PR checks fail
image

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Dec 3, 2024
@github-actions
Copy link

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

@github-actions github-actions bot closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants