add a separate scope to URL protocol and www #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eugenesvk changed the title eugenesvk force-pushed the url_protocol branch from 6e77009 to 276c45c Compare eugenesvk force-pushed the url_protocol branch from 276c45c to 9b73edd Compare 
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@ ## master #732 +/- ## ========================================= Coverage ? 36.07% ========================================= Files ? 7 Lines ? 1095 Branches ? 0 ========================================= Hits ? 395 Misses ? 700 Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I wanted to deemphasize protocol highlighting in links (
http) as well as the usually optionalwww., so added separate scopes to themSyntax tests failed locally before my edits, and the number of failed tests didn't change
(btw, got confused by https://github.com/SublimeText-Markdown/MarkdownEditing/blob/master/CONTRIBUTING.md again, if there are no milestones, would you please update the doc to reflect whatever actual scheme you're maintaining in this repo?)