Skip to content

Conversation

@samaroo
Copy link

@samaroo samaroo commented Dec 16, 2021

Description

I added two new props the the "Carousel" component: "endOfCarouselLink" and "beginningOfCarousel". The "endOfCarousel" prop takes a URL as an argument and redirects to that link when you try to scroll past the end of of the last slide in the carousel. Likewise, the "beginningOfCarousel" props takes a URL as an argument and redirects to that link when you try to navigate backwards when on the first slide. I modified the "advancePage" to handle the cases when you try to scroll past either end of the carousel and redirect to the appropriate link.

Motivation and Context

#294

How Has This Been Tested?

This was tested by hand using vue-play to make sure the changes work and do not break the current functionality of the carousel.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have included a vue-play example (if this is a new feature)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant