Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Conversation

aahnik
Copy link
Member

@aahnik aahnik commented Nov 6, 2020

Fixes #629

Description

  • Logs should contain time-stamps in the deployer's desired time-zone instead of server time.
  • Uplift ban from exponentiation ** as the cause of bug found and can be handled.
  • Hanging in case of certain long calculations can be prevented.
  • Reduce bot's response time by preventing the repetition of execution.

    earlier when there was no output after executing the code via python -c code, the bot would run eval(code).

  • add new command /e to run pythonic expressions.
  • add new commands /help and /code
  • remove the dependency on Makefile as it had only a few lines
  • add more detailed docstrings
  • make the readme instructions simpler to follow.
  • host the code for this in an independent repo, to make deploying and updating code on server steps easier.
  • fix all pylint errors

Here is a gif of the new behavior of the bot: Click to view full screen 👇

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancements
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.
Copy link
Member Author

@aahnik aahnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed all changes.

@mergify mergify bot merged commit e05673d into Python-World:master Nov 7, 2020
@aahnik aahnik deleted the enhance_runPython_bot branch November 7, 2020 13:08
@aahnik
Copy link
Member Author

aahnik commented Nov 7, 2020

thanks a lot for merging @AdityaJ7 and @tusharnankani.

This is a short article I wrote in Dev.to about this bot Start chatting with Python on Telegram

Screenshot from 2020-11-07 18-52-18

Please do read and share. 🤗

@github-actions
Copy link

Python World does not accept pull requests on this repository anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
@mergify mergify bot added the nice-job label Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.