Fixes querying nested fields in dynamic embedded docs #2647
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changing field lookup for
DynamicDocument
s when the field is nested in aDynamicEmbeddedDocument
.Before these changes, the code was creating a dynamic field when the container document is a dynamic document regardless of the field being nested in an embedded document. In which case the field should be looked up there.
This PR fixes #2251.
There are two new tests that evidence this and another error:
LookUpError
(the error in Querying dynamic field on DynamicEmbeddedDocument throws LookUpError #2251)DynamicEmbeddedDocument
has defined a value fordb_field
.